Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm cleanup #9293

Merged
merged 9 commits into from
Nov 6, 2024
Merged

npm cleanup #9293

merged 9 commits into from
Nov 6, 2024

Conversation

stevector
Copy link
Contributor

cleaning up some npm dependencies

@stevector stevector requested a review from a team as a code owner November 4, 2024 21:51
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9293-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@wiz-inc-b08cf2810f
Copy link

wiz-inc-b08cf2810f bot commented Nov 4, 2024 •
edited
Loading

Wiz Scan Summary

Scan Module Critical High Medium Low Info Total
IaC Misconfigurations 0 0 0 0 0 0
Vulnerabilities 0 13 9 2 0 24
Sensitive Data 0 0 0 0 0 0
Secrets 0 0 0 0 0 0
Total 0 13 9 2 0 24

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@stevector stevector marked this pull request as draft November 4, 2024 22:27
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9293-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9293-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9293-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

stevector
stevector commented Nov 5, 2024
View reviewed changes
gatsby-config.js
@@ -235,14 +235,6 @@ module.exports = {
},
`gatsby-transformer-sharp`,
`gatsby-plugin-sharp`,
{
resolve: "gatsby-plugin-web-font-loader",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears we weren't using this font at all.

@stevector
Copy link
Contributor Author

@rachelwhitton and @jazzsequence this one is not urgent, but I cleaned up some of our NPM dependencies, mostly by removing packages. I tracked the operations I did in cleanup.txt

stevector
stevector commented Nov 5, 2024
View reviewed changes
cleanup.txt Outdated
@@ -0,0 +1,14 @@
npm uninstall algoliasearch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should delete this file before merging

@stevector stevector marked this pull request as ready for review November 5, 2024 16:06
rachelwhitton
rachelwhitton approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@rachelwhitton rachelwhitton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran local VRT with passing results, looks good to me 👍

screencapture-localhost-9323-2024-11-05-10_22_07 (1)

@rachelwhitton rachelwhitton added the dependencies Pull requests that update a dependency file label Nov 5, 2024
@rachelwhitton rachelwhitton changed the title WIP - npm cleanup npm cleanup Nov 5, 2024
jazzsequence
jazzsequence approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@jazzsequence jazzsequence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't updating anything, it's just removing unused things?

@stevector
Copy link
Contributor Author

@jazzsequence it also contained some updates triggered by npm update msgpackr which I ran to fix a single notice in npm audit. Then npm audit fix did some other additional updates. Resolving most of the warning seems like it would require a major version update to Gatsby which I don't think is worth doing.

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9293-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@rachelwhitton rachelwhitton merged commit 412ff52 into main Nov 6, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelwhitton rachelwhitton rachelwhitton approved these changes

@jazzsequence jazzsequence jazzsequence approved these changes

Assignees

@stevector stevector

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevector @jazzsequence @rachelwhitton